fix: parse date strings as UTC

For posts, comments, and other objects, the `published` attribute is a
string containing an ISO 8601 timestamp. This timestamp is UTC, though
it is not explicit in the string's contents. When the `Date` constructor
is used on such strings, they are parsed as though they are local
timestamps. According to [1]:

> When the time zone offset is absent, date-only forms are
> interpreted as a UTC time and date-time forms are interpreted as local
> time. This is due to a historical spec error that was not consistent
> with ISO 8601 but could not be changed due to web
> compatibility.

This patch explicitly appends a 'Z' to the `published` string when it is
used as the argument to the `Date` constructor.

[1]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date
This commit is contained in:
Thomas J Faughnan Jr committed 2023-07-28 20:02:01 -04:00
1 parent 035cdc23ed
commit 34c712c01c
7 files changed
+7 -7

No files matched your search

+1 -1
View File
@@ -33,7 +33,7 @@
</div>
<span class="flex flex-row items-center gap-1 text-sm">
<Icon src={Calendar} width={16} height={16} mini />
<RelativeDate date={new Date(site.site.published)} />
<RelativeDate date={new Date(site.site.published + 'Z')} />
</span>
<div class="text-sm flex flex-row flex-wrap gap-3">
<span class="flex flex-row items-center gap-1">
@@ -101,7 +101,7 @@
{node.comment_view.counts.score}
</div>
{/if}
<RelativeDate date={new Date(node.comment_view.comment.published)} />
<RelativeDate date={new Date(node.comment_view.comment.published + 'Z')} />
<span>•</span>
<span>
{Math.floor(
@@ -16,7 +16,7 @@
deleted={false}
featured={false}
nsfw={comment.post.nsfw}
published={new Date(comment.post.published)}
published={new Date(comment.post.published + 'Z')}
saved={false}
/>
<Button
@@ -87,7 +87,7 @@
</div>
<span class="flex flex-row items-center gap-1 text-sm">
<Icon src={Calendar} width={16} height={16} mini />
<RelativeDate date={new Date(community_view.community.published)} />
<RelativeDate date={new Date(community_view.community.published + 'Z')} />
</span>
<div class="text-sm flex flex-row flex-wrap gap-3">
<span class="flex flex-row items-center gap-1">
+1 -1
View File
@@ -22,7 +22,7 @@
<PostMeta
community={post.community}
user={post.creator}
published={new Date(post.post.published)}
published={new Date(post.post.published + 'Z')}
upvotes={post.counts.upvotes}
downvotes={post.counts.downvotes}
deleted={post.post.deleted}
+1 -1
View File
@@ -107,7 +107,7 @@
locked={postData.post.locked}
featured={postData.post.featured_community || postData.post.featured_local}
nsfw={postData.post.nsfw}
published={new Date(postData.post.published)}
published={new Date(postData.post.published + 'Z')}
saved={postData.saved}
/>
<h1 class="font-bold text-lg">{post.name}</h1>
+1 -1
View File
@@ -183,7 +183,7 @@
<span class="flex flex-row items-center gap-1 text-sm">
<Icon src={Calendar} width={16} height={16} mini />
<span class="capitalize">
<RelativeDate date={new Date(data.person_view.person.published)} />
<RelativeDate date={new Date(data.person_view.person.published + 'Z')} />
</span>
</span>
<div class="text-sm flex flex-row flex-wrap gap-3">