From e57caa2cabaf7795f6fe1906d00882a5b1b79cf8 Mon Sep 17 00:00:00 2001 From: sevonj <100710152+sevonj@users.noreply.github.com> Date: Sun, 15 Jun 2025 19:57:53 +0300 Subject: [PATCH] fix: /inbox/messages: show chats without response (#567) * fix: inbox list chats without response * misc: only show username if it's you --------- Co-authored-by: James Xylight --- src/routes/inbox/messages/+page.svelte | 40 ++++++++++++++++++-------- 1 file changed, 28 insertions(+), 12 deletions(-) diff --git a/src/routes/inbox/messages/+page.svelte b/src/routes/inbox/messages/+page.svelte index b01c42ca..ce56a5f3 100644 --- a/src/routes/inbox/messages/+page.svelte +++ b/src/routes/inbox/messages/+page.svelte @@ -13,10 +13,17 @@ user: Person message: { date: Date + last_sender: number content: string } } + function getOtherPartyId(message: PrivateMessageView): number { + return message.creator.id == profile.data.user?.local_user_view.person.id + ? message.recipient.id + : message.creator.id + } + function filterDuplicates(array: T[], predicate: (item: T) => K): T[] { const seen = new Set() return array.filter(element => { @@ -33,15 +40,23 @@ function conversationPreviews( conversations: PrivateMessageView[], ): ConversationPreview[] { - const deduplicated = filterDuplicates(conversations, i => i.creator.id) + const deduplicated = filterDuplicates(conversations, i => + getOtherPartyId(i), + ) - return deduplicated.map(i => ({ - user: i.creator, - message: { - date: publishedToDate(i.private_message.published), - content: i.private_message.content, - }, - })) + return deduplicated + .filter(c => c.creator.id != c.recipient.id) // you messaged yourself + .map(i => ({ + user: + i.creator.id != profile.data.user?.local_user_view.person.id + ? i.creator + : i.recipient, + message: { + date: publishedToDate(i.private_message.published), + last_sender: i.creator.id, + content: i.private_message.content, + }, + })) } let { data } = $props() @@ -56,9 +71,7 @@ {:then data} {@const conversations = data.private_messages} - {@const previews = conversationPreviews(conversations).filter( - c => c.user.id != profile.data?.user?.local_user_view.person.id, - )} + {@const previews = conversationPreviews(conversations)}