fix: strange crash with {#if} branch for site data
This commit is contained in:
3 files changed
+28
-28
No files matched your search
@@ -27,13 +27,7 @@
|
||||
class?: ClassValue
|
||||
}
|
||||
|
||||
let {
|
||||
site,
|
||||
taglines = undefined,
|
||||
admins = undefined,
|
||||
version = undefined,
|
||||
class: clazz = '',
|
||||
}: Props = $props()
|
||||
let { site, taglines, admins, version, class: clazz = '' }: Props = $props()
|
||||
</script>
|
||||
|
||||
<aside
|
||||
|
||||
@@ -156,8 +156,10 @@
|
||||
<Blobs seed={title ?? data.text} />
|
||||
</div>
|
||||
{/if}
|
||||
<Icon src={data.icon} solid size="48" />
|
||||
<h1 class="font-display text-3xl font-medium text-left">
|
||||
<Icon src={data.icon} solid size="40" />
|
||||
<h1
|
||||
class="font-display text-xl md:text-2xl xl:text-3xl font-medium text-left overflow-hidden overflow-ellipsis line-clamp-2"
|
||||
>
|
||||
{title ?? data.text}
|
||||
</h1>
|
||||
<div class="text-slate-600 dark:text-zinc-400">
|
||||
|
||||
+23
-19
@@ -149,24 +149,28 @@
|
||||
<Navbar class={c} style={s} />
|
||||
{/snippet}
|
||||
{#snippet suffix({ class: c })}
|
||||
{#if page.data.slots?.sidebar?.component}
|
||||
{@const SvelteComponent = page.data.slots.sidebar.component}
|
||||
<SvelteComponent
|
||||
{...page.data.slots.sidebar.props}
|
||||
class={[c, 'p-3 sm:p-6']}
|
||||
/>
|
||||
{:else if site.data}
|
||||
<InstanceCard
|
||||
site={site.data.site_view}
|
||||
taglines={site.data.taglines}
|
||||
admins={site.data.admins}
|
||||
version={site.data.version}
|
||||
class={[c, 'p-3 sm:p-6']}
|
||||
/>
|
||||
{:else}
|
||||
<div class="h-64 w-full grid place-items-center">
|
||||
<Spinner width={32} />
|
||||
</div>
|
||||
{/if}
|
||||
<!--strange issue, proabably to do with dynamic components-->
|
||||
<!--the {#if} branch for InstanceCard is getting rendered even if site.data is null, causing crashes-->
|
||||
{#key site.data}
|
||||
{#if page.data.slots?.sidebar?.component}
|
||||
{@const SvelteComponent = page.data.slots.sidebar.component}
|
||||
<SvelteComponent
|
||||
{...page.data.slots.sidebar.props}
|
||||
class={[c, 'p-3 sm:p-6']}
|
||||
/>
|
||||
{:else if site.data?.site_view}
|
||||
<InstanceCard
|
||||
site={site.data.site_view}
|
||||
taglines={site.data.taglines}
|
||||
admins={site.data.admins}
|
||||
version={site.data.version}
|
||||
class={[c, 'p-3 sm:p-6']}
|
||||
/>
|
||||
{:else}
|
||||
<div class="h-64 w-full grid place-items-center">
|
||||
<Spinner width={32} />
|
||||
</div>
|
||||
{/if}
|
||||
{/key}
|
||||
{/snippet}
|
||||
</Shell>
|
||||
Reference in new issue
Block a user