From bea9e0b832b8dbf1745dad69f3f9ec8799c16c7d Mon Sep 17 00:00:00 2001 From: James Xylight Date: Fri, 25 Jul 2025 15:36:07 -0700 Subject: [PATCH] fix: failed scrolling with comment jumping --- .../components/lemmy/comment/Comment.svelte | 23 +++++++++++-------- .../comment/CommentListVirtualizer.svelte | 1 - .../components/lemmy/comment/Comments.svelte | 20 +++------------- src/lib/components/markdown/Markdown.svelte | 3 ++- src/routes/+error.svelte | 3 +-- .../[id=integer]/CommentProvider.svelte | 15 +++++++++++- 6 files changed, 34 insertions(+), 31 deletions(-) diff --git a/src/lib/components/lemmy/comment/Comment.svelte b/src/lib/components/lemmy/comment/Comment.svelte index c61ce8d6..70f51547 100644 --- a/src/lib/components/lemmy/comment/Comment.svelte +++ b/src/lib/components/lemmy/comment/Comment.svelte @@ -16,6 +16,7 @@ import ShieldIcon from '../moderation/ShieldIcon.svelte' import CommentForm from './CommentForm.svelte' import type { CommentNodeI } from './comments.svelte' + import { page } from '$app/state' interface Props { node: CommentNodeI @@ -109,12 +110,7 @@ {/if}
  • {#if meta} @@ -176,12 +172,21 @@
    {#if actions} [nodes[index]], v => (nodes[index] = v[0])} {post} /> diff --git a/src/lib/components/lemmy/comment/Comments.svelte b/src/lib/components/lemmy/comment/Comments.svelte index 39c6ec35..aa8ae865 100644 --- a/src/lib/components/lemmy/comment/Comments.svelte +++ b/src/lib/components/lemmy/comment/Comments.svelte @@ -7,7 +7,6 @@ import { errorMessage } from '$lib/lemmy/error' import type { Post } from 'lemmy-js-client' import { Button, toast } from 'mono-svelte' - import { onMount } from 'svelte' import { ArrowDownCircle, Icon } from 'svelte-hero-icons' import Comment from './Comment.svelte' import Comments from './Comments.svelte' @@ -15,23 +14,10 @@ interface Props { nodes: CommentNodeI[] - isParent: boolean post: Post } - let { nodes = $bindable(), isParent, post }: Props = $props() - - let hydrated = $state(false) - - onMount(() => { - hydrated = true - if (isParent && page.url.hash && browser) { - document.getElementById(page.url.hash)?.scrollIntoView({ - behavior: 'smooth', - block: 'center', - }) - } - }) + let { nodes = $bindable(), post }: Props = $props() let childrenPage = 0 @@ -114,12 +100,12 @@ bind:open={nodes[index].expanded} > {#if node.children?.length > 0} - + {/if} {#if node.comment_view.counts.child_count > 0 && node.children.length == 0} diff --git a/src/lib/components/markdown/Markdown.svelte b/src/lib/components/markdown/Markdown.svelte index 7e81b75b..5a026ca2 100644 --- a/src/lib/components/markdown/Markdown.svelte +++ b/src/lib/components/markdown/Markdown.svelte @@ -116,6 +116,7 @@ {#if profile.current?.jwt} @@ -154,7 +167,7 @@ {:else}
    - +
    {/if}