From 119ab5394667f3b80f8cf89683948fc8cc8b491a Mon Sep 17 00:00:00 2001 From: Xyphyn Date: Thu, 28 Sep 2023 17:08:37 -0700 Subject: [PATCH 01/13] feat: add v0.19.0 support --- TODO.md | 3 ++ package.json | 2 +- src/hooks.server.ts | 4 +- src/lib/auth.ts | 53 ++++++++++++------- .../lemmy/ObjectAutocomplete.svelte | 1 - .../components/lemmy/comment/Comment.svelte | 1 - .../lemmy/comment/CommentForm.svelte | 1 - .../lemmy/comment/CommentVote.svelte | 2 - .../components/lemmy/comment/Comments.svelte | 1 - .../lemmy/community/CommunityCard.svelte | 2 - .../lemmy/community/CommunityForm.svelte | 2 - .../lemmy/modal/PrivateMessageModal.svelte | 1 - .../lemmy/moderation/BanModal.svelte | 2 - .../lemmy/moderation/ModerationMenu.svelte | 2 - .../lemmy/moderation/RemoveModal.svelte | 6 --- .../lemmy/moderation/ReportModal.svelte | 2 - .../components/lemmy/moderation/moderation.ts | 2 +- src/lib/components/lemmy/post/PostForm.svelte | 7 ++- src/lib/components/lemmy/post/helpers.ts | 7 +-- src/lib/components/ui/Navbar.svelte | 2 +- src/lib/lemmy.ts | 44 ++++++++++----- src/lib/lemmy/contentview.ts | 7 --- src/lib/lemmy/user.ts | 3 -- src/lib/util.ts | 11 +++- src/lib/version.ts | 31 +++++++++++ src/routes/+page.ts | 1 - src/routes/admin/+layout.ts | 4 +- src/routes/admin/applications/+page.ts | 1 - .../admin/applications/Application.svelte | 1 - src/routes/admin/config/+page.svelte | 1 - src/routes/admin/federation/+page.svelte | 2 - src/routes/admin/federation/+page.ts | 4 +- src/routes/admin/taglines/+page.svelte | 1 - src/routes/admin/team/+page.svelte | 1 - src/routes/c/[name]/+layout.ts | 2 - .../c/[name]/settings/team/+page.svelte | 3 -- src/routes/comment/[instance]/[id]/+page.ts | 1 - src/routes/communities/+page.ts | 2 - src/routes/communities/Subscribe.svelte | 1 - src/routes/create/post/+page.ts | 8 +-- src/routes/inbox/+page.svelte | 4 +- src/routes/inbox/+page.ts | 1 - src/routes/inbox/InboxItem.svelte | 3 -- src/routes/instances/+page.ts | 7 +-- src/routes/login/+page.svelte | 21 ++++++-- src/routes/moderation/+page.ts | 1 - src/routes/moderation/Report.svelte | 7 +-- src/routes/modlog/+page.ts | 1 - src/routes/post/[instance]/+page.ts | 3 +- .../post/[instance]/[id=integer]/+page.svelte | 3 -- .../post/[instance]/[id=integer]/+page.ts | 2 - .../profile/(local_user)/blocks/+page.svelte | 2 - .../(local_user)/password/+page.svelte | 4 +- .../(local_user)/settings/+page.svelte | 4 +- src/routes/profile/+layout.ts | 3 +- src/routes/profile/user/+page.ts | 1 - src/routes/saved/+page.ts | 11 ++-- src/routes/search/+page.ts | 2 - src/routes/u/[name]/+page.svelte | 3 +- src/routes/u/[name]/+page.ts | 1 - tests/version.test.ts | 21 ++++++++ yarn.lock | 8 +-- 62 files changed, 188 insertions(+), 157 deletions(-) create mode 100644 TODO.md create mode 100644 src/lib/version.ts create mode 100644 tests/version.test.ts diff --git a/TODO.md b/TODO.md new file mode 100644 index 00000000..865ae160 --- /dev/null +++ b/TODO.md @@ -0,0 +1,3 @@ +# Todo + +- [ ] Add blocking instances and stuff diff --git a/package.json b/package.json index f60a97ac..87042102 100644 --- a/package.json +++ b/package.json @@ -21,7 +21,7 @@ "@vite-pwa/sveltekit": "^0.2.5", "autoprefixer": "^10.4.16", "jsdom": "^22.1.0", - "lemmy-js-client": "^0.18.1", + "lemmy-js-client": "^0.19.0-rc.13", "markdown-it-container": "^3.0.0", "markdown-it-sub": "^1.0.0", "markdown-it-sup": "^1.0.0", diff --git a/src/hooks.server.ts b/src/hooks.server.ts index edbac059..97bbad35 100644 --- a/src/hooks.server.ts +++ b/src/hooks.server.ts @@ -1,7 +1,9 @@ function buildUrl(inputUrl: URL): URL { let withoutCors = inputUrl.pathname.replace('/cors/', '') - if (!withoutCors.startsWith('https://')) { + if ( + !(withoutCors.startsWith('https://') || withoutCors.startsWith('http://')) + ) { withoutCors = 'https://' + withoutCors } diff --git a/src/lib/auth.ts b/src/lib/auth.ts index 0fd799ca..0b92e4f7 100644 --- a/src/lib/auth.ts +++ b/src/lib/auth.ts @@ -1,15 +1,16 @@ import { amModOfAny } from '$lib/components/lemmy/moderation/moderation.js' import { toast } from 'mono-svelte' import { DEFAULT_INSTANCE_URL, instance } from '$lib/instance.js' -import { getClient, site } from '$lib/lemmy.js' +import { client, getClient, site } from '$lib/lemmy.js' import { userSettings } from '$lib/settings.js' -import { moveItem } from '$lib/util.js' +import { instanceToURL, moveItem } from '$lib/util.js' import { LemmyHttp, type GetSiteResponse, type MyUserInfo, } from 'lemmy-js-client' import { get, writable } from 'svelte/store' +import { MINIMUM_VERSION, versionIsSupported } from '$lib/version.js' const getDefaultProfile = (): Profile => ({ id: -1, @@ -87,13 +88,21 @@ profile.subscribe(async (p) => { instance.set(p.instance) // fetch the user because p.user is undefined const user = await userFromJwt(p.jwt, p.instance) + .then((user) => { + if (!user?.user) + toast({ + content: 'Your login has expired. Re-login to fix this issue.', + type: 'warning', + }) + site.set(user?.site) - if (!user?.user) - toast({ - content: 'Your login has expired. Re-login to fix this issue.', - type: 'warning', + return user }) - site.set(user?.site) + .catch((err) => { + toast({ content: err as any, type: 'error' }) + }) + + if (!user?.user) return profile.update(() => ({ ...p, @@ -105,13 +114,17 @@ profile.subscribe(async (p) => { export async function setUser(jwt: string, inst: string, username: string) { try { - new URL(`https://${inst}`) + new URL(instanceToURL(inst)) } catch (err) { return } const user = await userFromJwt(jwt, inst) - if (!user) { + .then((u) => u) + .catch((err) => { + toast({ content: err as any, type: 'error' }) + }) + if (!user?.user) { toast({ content: 'Failed to fetch your user. Is your instance down?', type: 'error', @@ -152,9 +165,7 @@ async function userFromJwt( jwt: string, instance: string ): Promise<{ user: PersonData; site: GetSiteResponse } | undefined> { - const sitePromise = getClient(instance).getSite({ - auth: jwt, - }) + const sitePromise = client({ instanceURL: instance, auth: jwt }).getSite() let timer = setTimeout( () => @@ -170,6 +181,12 @@ async function userFromJwt( return r }) + if (!versionIsSupported(site.version, MINIMUM_VERSION)) { + throw new Error( + `This version of Photon only supports Lemmy instances with version ${MINIMUM_VERSION} or higher. This Lemmy instance is running: ${site.version}` + ) + } + const myUser = site.my_user if (!myUser) return undefined @@ -250,6 +267,10 @@ export async function setUserID(id: number) { if (prof?.jwt) { const user = await userFromJwt(prof.jwt, prof.instance) + .then((u) => u) + .catch((err) => { + toast({ content: err as any, type: 'error' }) + }) instance.set(prof.instance) prof.user = user?.user prof.avatar = user?.user.local_user_view.person.avatar @@ -276,16 +297,12 @@ export function moveProfile(id: number, up: boolean) { } const getNotificationCount = async (jwt: string, mod: boolean) => { - const unreads = await getClient().getUnreadCount({ - auth: jwt, - }) + const unreads = await getClient().getUnreadCount() let reports: number = 0 if (mod) { - const reportRes = await getClient().getReportCount({ - auth: jwt, - }) + const reportRes = await getClient().getReportCount({}) reports = reportRes.comment_reports + diff --git a/src/lib/components/lemmy/ObjectAutocomplete.svelte b/src/lib/components/lemmy/ObjectAutocomplete.svelte index 7d497666..d1bc4977 100644 --- a/src/lib/components/lemmy/ObjectAutocomplete.svelte +++ b/src/lib/components/lemmy/ObjectAutocomplete.svelte @@ -22,7 +22,6 @@ search={async (q) => { const results = await getClient().search({ q: q || ' ', - auth: jwt, type_: 'Communities', limit: 20, listing_type: listing_type, diff --git a/src/lib/components/lemmy/comment/Comment.svelte b/src/lib/components/lemmy/comment/Comment.svelte index 48aec0a1..6f8786a4 100644 --- a/src/lib/components/lemmy/comment/Comment.svelte +++ b/src/lib/components/lemmy/comment/Comment.svelte @@ -41,7 +41,6 @@ try { await getClient().editComment({ - auth: $profile.jwt, comment_id: node.comment_view.comment.id, content: newComment, }) diff --git a/src/lib/components/lemmy/comment/CommentForm.svelte b/src/lib/components/lemmy/comment/CommentForm.svelte index 9d6749e9..081d1330 100644 --- a/src/lib/components/lemmy/comment/CommentForm.svelte +++ b/src/lib/components/lemmy/comment/CommentForm.svelte @@ -31,7 +31,6 @@ try { const response = await getClient().createComment({ - auth: $profile.jwt, content: value, post_id: postId, parent_id: parentId, diff --git a/src/lib/components/lemmy/comment/CommentVote.svelte b/src/lib/components/lemmy/comment/CommentVote.svelte index 3eb3480d..ea9cc8c0 100644 --- a/src/lib/components/lemmy/comment/CommentVote.svelte +++ b/src/lib/components/lemmy/comment/CommentVote.svelte @@ -35,7 +35,6 @@ await getClient() .likeComment({ score: upvoted ? 0 : 1, - auth: $profile.jwt, comment_id: commentId, }) .catch((_) => undefined) @@ -59,7 +58,6 @@ await getClient() .likeComment({ score: upvoted ? 0 : -1, - auth: $profile.jwt, comment_id: commentId, }) .catch((_) => undefined) diff --git a/src/lib/components/lemmy/comment/Comments.svelte b/src/lib/components/lemmy/comment/Comments.svelte index a3b9fae2..def1f66f 100644 --- a/src/lib/components/lemmy/comment/Comments.svelte +++ b/src/lib/components/lemmy/comment/Comments.svelte @@ -43,7 +43,6 @@ parent.loading = true const newComments = await getClient($page.params.instance).getComments({ - auth: $profile?.jwt, max_depth: 5, parent_id: parent.comment_view.comment.id, type_: 'All', diff --git a/src/lib/components/lemmy/community/CommunityCard.svelte b/src/lib/components/lemmy/community/CommunityCard.svelte index 5f3db57d..385c7e2a 100644 --- a/src/lib/components/lemmy/community/CommunityCard.svelte +++ b/src/lib/components/lemmy/community/CommunityCard.svelte @@ -41,7 +41,6 @@ try { await getClient().followCommunity({ - auth: $profile.jwt, community_id: community_view.community.id, follow: !subscribed, }) @@ -61,7 +60,6 @@ try { await getClient().blockCommunity({ - auth: $profile.jwt, community_id: community_view.community.id, block: !blocked, }) diff --git a/src/lib/components/lemmy/community/CommunityForm.svelte b/src/lib/components/lemmy/community/CommunityForm.svelte index c02d86c8..8d7aa724 100644 --- a/src/lib/components/lemmy/community/CommunityForm.svelte +++ b/src/lib/components/lemmy/community/CommunityForm.svelte @@ -49,7 +49,6 @@ const res = edit ? await getClient().editCommunity({ - auth: $profile.jwt, title: formData.displayName, description: formData.sidebar, nsfw: formData.nsfw, @@ -59,7 +58,6 @@ community_id: edit, }) : await getClient().createCommunity({ - auth: $profile.jwt, name: formData.name, title: formData.displayName, description: formData.sidebar, diff --git a/src/lib/components/lemmy/modal/PrivateMessageModal.svelte b/src/lib/components/lemmy/modal/PrivateMessageModal.svelte index f4adb6f2..fba0e753 100644 --- a/src/lib/components/lemmy/modal/PrivateMessageModal.svelte +++ b/src/lib/components/lemmy/modal/PrivateMessageModal.svelte @@ -20,7 +20,6 @@ try { await getClient().createPrivateMessage({ - auth: $profile.jwt, content: message, recipient_id: user.id, }) diff --git a/src/lib/components/lemmy/moderation/BanModal.svelte b/src/lib/components/lemmy/moderation/BanModal.svelte index 5235cee8..43d31c54 100644 --- a/src/lib/components/lemmy/moderation/BanModal.svelte +++ b/src/lib/components/lemmy/moderation/BanModal.svelte @@ -62,7 +62,6 @@ if (community) { await getClient().banFromCommunity({ - auth: $profile.jwt, ban: !banned, community_id: community.id, person_id: item.id, @@ -72,7 +71,6 @@ }) } else { await getClient().banPerson({ - auth: $profile.jwt, ban: !banned, person_id: item.id, reason: reason || undefined, diff --git a/src/lib/components/lemmy/moderation/ModerationMenu.svelte b/src/lib/components/lemmy/moderation/ModerationMenu.svelte index a591a692..733f01d3 100644 --- a/src/lib/components/lemmy/moderation/ModerationMenu.svelte +++ b/src/lib/components/lemmy/moderation/ModerationMenu.svelte @@ -29,7 +29,6 @@ try { await getClient().lockPost({ - auth: $profile.jwt, locked: lock, post_id: item.post.id, }) @@ -60,7 +59,6 @@ try { await getClient().featurePost({ feature_type: toInstance ? 'Local' : 'Community', - auth: $profile.jwt, featured: pinned, post_id: item.post.id, }) diff --git a/src/lib/components/lemmy/moderation/RemoveModal.svelte b/src/lib/components/lemmy/moderation/RemoveModal.svelte index 6ac84bfc..4989d8cc 100644 --- a/src/lib/components/lemmy/moderation/RemoveModal.svelte +++ b/src/lib/components/lemmy/moderation/RemoveModal.svelte @@ -57,13 +57,11 @@ if (purge) { if (isCommentView(item)) { await getClient(undefined, fetch).purgeComment({ - auth: $profile.jwt, comment_id: item.comment.id, reason: reason, }) } else { await getClient(undefined, fetch).purgePost({ - auth: $profile.jwt, post_id: item.post.id, reason: reason, }) @@ -91,7 +89,6 @@ if (privateMessage) { await getClient() .createPrivateMessage({ - auth: $profile.jwt, content: replyReason, recipient_id: isCommentView(item) ? item.comment.creator_id @@ -106,7 +103,6 @@ } else { await getClient() .createComment({ - auth: $profile.jwt, content: replyReason, post_id: item.post.id, parent_id: isCommentView(item) ? item.comment.id : undefined, @@ -122,7 +118,6 @@ if (isCommentView(item)) { await getClient().removeComment({ - auth: $profile.jwt, comment_id: item.comment.id, removed: !removed, reason: reason || undefined, @@ -130,7 +125,6 @@ item.comment.removed = !removed } else if (isPostView(item)) { await getClient().removePost({ - auth: $profile.jwt, post_id: item.post.id, removed: !removed, reason: reason || undefined, diff --git a/src/lib/components/lemmy/moderation/ReportModal.svelte b/src/lib/components/lemmy/moderation/ReportModal.svelte index 7103bf3c..5b19eaea 100644 --- a/src/lib/components/lemmy/moderation/ReportModal.svelte +++ b/src/lib/components/lemmy/moderation/ReportModal.svelte @@ -27,13 +27,11 @@ try { if (isComment(item)) { await getClient().createCommentReport({ - auth: $profile.jwt, comment_id: item.comment.id, reason: reason, }) } else if (isPost(item)) { await getClient().createPostReport({ - auth: $profile.jwt, post_id: item.post.id, reason: reason, }) diff --git a/src/lib/components/lemmy/moderation/moderation.ts b/src/lib/components/lemmy/moderation/moderation.ts index df6f7237..aae2850b 100644 --- a/src/lib/components/lemmy/moderation/moderation.ts +++ b/src/lib/components/lemmy/moderation/moderation.ts @@ -78,7 +78,7 @@ export const amMod = (me: MyUserInfo, community: Community) => export const amModOfAny = (me?: MyUserInfo) => me && (me.moderates.length > 0 || isAdmin(me)) -export const isAdmin = (me: MyUserInfo) => me.local_user_view.person.admin +export const isAdmin = (me: MyUserInfo) => me.local_user_view.local_user.admin export const removalTemplate = ( input: string, diff --git a/src/lib/components/lemmy/post/PostForm.svelte b/src/lib/components/lemmy/post/PostForm.svelte index d8c46520..3ba03898 100644 --- a/src/lib/components/lemmy/post/PostForm.svelte +++ b/src/lib/components/lemmy/post/PostForm.svelte @@ -63,7 +63,6 @@ communitySearch = passedCommunity.name } else { const list = await getClient().listCommunities({ - auth: $profile?.jwt, type_: 'All', sort: 'Active', limit: 40, @@ -107,7 +106,6 @@ } const post = await getClient().editPost({ - auth: $profile.jwt, name: data.title, body: data.body, url: data.url || undefined, @@ -121,10 +119,11 @@ dispatcher('submit', post.post_view) } else { - let image = data.image ? await uploadImage(data.image[0], $profile.instance, $profile.jwt) : undefined + let image = data.image + ? await uploadImage(data.image[0], $profile.instance, $profile.jwt) + : undefined data.url = image || data.url || undefined const post = await getClient().createPost({ - auth: $profile.jwt, community_id: data.community!, name: data.title, body: data.body, diff --git a/src/lib/components/lemmy/post/helpers.ts b/src/lib/components/lemmy/post/helpers.ts index d573c008..be361239 100644 --- a/src/lib/components/lemmy/post/helpers.ts +++ b/src/lib/components/lemmy/post/helpers.ts @@ -1,9 +1,6 @@ import { getInstance } from '$lib/lemmy.js' import type { CommentView, PersonView, Post, PostView } from 'lemmy-js-client' -export const isMutable = (post: PostView, me: PersonView) => - (me.person.admin && post.post.local) || me.person.id == post.creator.id - export const isCommentMutable = (comment: CommentView, me: PersonView) => me.person.id == comment.creator.id @@ -13,8 +10,8 @@ export const bestImageURL = ( width: number = 1024 ) => { if (width > 1024) { - if (post.url) return `${post.url}?format=webp` - else if (post.thumbnail_url) return `${post.thumbnail_url}?format=webp` + if (post.url) return `${post.url}?format=webp` + else if (post.thumbnail_url) return `${post.thumbnail_url}?format=webp` } if (compact && post.thumbnail_url) diff --git a/src/lib/components/ui/Navbar.svelte b/src/lib/components/ui/Navbar.svelte index 86b8e011..04a3fb6c 100644 --- a/src/lib/components/ui/Navbar.svelte +++ b/src/lib/components/ui/Navbar.svelte @@ -113,7 +113,7 @@ + {/if}