v2: replace @tanstack/svelte-virtual with custom virtualizer (#516)

* impr: use custom virtualizer for post feeds

* fix: use resizeobserver to update heights dynamically

* fix: add overcsan and initialOffset for items

* misc: update package.json (remove tanstack)

* misc: use binary search to improve performance

* fix: use translate for cheap gpu composite time

* fix: reduce recalculate calls

* feat: re-add list restore

* fix: use relative instead of translations

* misc: add ssr support to virtualizer

* fix: onload scroll broken
This commit is contained in:
Xylight authored and GitHub committed 2025-05-04 14:04:21 -07:00
1 parent af02883314
commit 472aa00e65
8 files changed
+303 -164

No files matched your search

@@ -374,6 +374,13 @@
{$t('routes.post.commentCount')}
</div>
</header>
{#if !page.url.searchParams.get('noVirtualize')}
<noscript>
<Button href="?noVirtualize=true" class="block">
{$t('routes.post.loadComments')}
</Button>
</noscript>
{/if}
{#await data.comments.value}
<div class="flex flex-col gap-4">
{#each new Array(10) as empty, index}
@@ -400,6 +407,7 @@
focus={data.thread.value.focus}
onupdate={reloadComments}
bind:sort={data.commentSort.value}
virtualize={!page.url.searchParams.get('noVirtualize')}
/>
{#if comments.comments.length == 0}
<Placeholder
@@ -3,6 +3,7 @@
import { profile } from '$lib/auth.svelte'
import CommentForm from '$lib/components/lemmy/comment/CommentForm.svelte'
import CommentListVirtualizer from '$lib/components/lemmy/comment/CommentListVirtualizer.svelte'
import Comments from '$lib/components/lemmy/comment/Comments.svelte'
import { buildCommentsTree } from '$lib/components/lemmy/comment/comments.svelte'
import EndPlaceholder from '$lib/components/ui/EndPlaceholder.svelte'
import { instance } from '$lib/instance.svelte'
@@ -32,6 +33,7 @@
sort?: CommentSortType
onupdate?: () => void
focus?: string
virtualize?: boolean
}
let {
@@ -40,6 +42,7 @@
sort = $bindable(),
onupdate,
focus,
virtualize = true,
}: Props = $props()
let comments = $state(passedComments)
@@ -128,8 +131,16 @@
</Button>
</div>
{/if}
<CommentListVirtualizer
post={post.post_view.post}
nodes={tree}
scrollTo={focus}
/>
{#if virtualize}
<CommentListVirtualizer
post={post.post_view.post}
nodes={tree}
scrollTo={focus}
/>
{:else}
<div class="divide-y divide-slate-200 dark:divide-zinc-800">
<div class="-mx-4 sm:-mx-6 px-4 sm:px-6">
<Comments isParent={true} bind:nodes={tree} post={post.post_view.post} />
</div>
</div>
{/if}