perf: improve initial virtual list render speed by calculating height once

This commit is contained in:
James Xylight committed 2025-07-12 11:35:50 -07:00
1 parent c969a32767
commit 3cd4864748
4 files changed
+57 -29

No files matched your search

@@ -50,6 +50,7 @@
let hasMore = $state(true)
async function loadMore() {
console.log(hasMore, loading)
if (!hasMore || loading) return
try {
@@ -255,7 +256,14 @@
</EndPlaceholder>
</div>
{/if}
<InfiniteScroll window threshold={1000} on:loadMore={loadMore} />
<InfiniteScroll
window
threshold={600}
on:loadMore={() => {
console.log('loadMore triggered')
loadMore()
}}
/>
{/if}
{@render children?.()}
</ul>
+28 -11
View File
@@ -1,7 +1,7 @@
<script lang="ts" generics="T">
import { browser } from '$app/environment'
import { debounce } from 'mono-svelte/util/time'
import { onDestroy, untrack, type Snippet } from 'svelte'
import { onDestroy, onMount, untrack, type Snippet } from 'svelte'
import type { HTMLAttributes } from 'svelte/elements'
import { innerHeight } from 'svelte/reactivity/window'
@@ -72,15 +72,6 @@
let viewportHeight = $state(0)
let visibleItems = $state<{ index: number; offset: number }[]>([])
// Initial render
$effect.pre(() => {
if (virtualListEl && browser) {
untrack(() => {
visibleItems = updateVisibleItems()
})
}
})
$effect.pre(() => {
if (items.length > itemHeights.length) {
const missing = items.length - itemHeights.length
@@ -88,6 +79,14 @@
}
})
$effect(() => {
if (items.length) {
untrack(() => {
visibleItems = updateVisibleItems()
})
}
})
function findFirstVisibleIndex(
scrollTop: number,
cumulativeHeights: number[],
@@ -146,7 +145,6 @@
const newHeight = entry.contentRect.height
if (itemHeights[index] !== newHeight) {
itemHeights[index] = newHeight
visibleItems = updateVisibleItems()
}
}
}, debounceResize)
@@ -179,6 +177,25 @@
})
}
})
onMount(() => {
if (virtualListEl && browser) {
Array.from(virtualListEl.children).forEach(node => {
const indexAttr = node.getAttribute('data-index')
if (indexAttr === null) return
const index = Number(indexAttr)
if (isNaN(index)) return
const newHeight = node.getBoundingClientRect().height
if (itemHeights[index] !== newHeight) {
itemHeights[index] = newHeight
}
})
untrack(() => {
visibleItems = updateVisibleItems()
})
}
})
</script>
<svelte:window
+5 -5
View File
@@ -16,8 +16,8 @@
let { data = $bindable() } = $props()
let type = $state(data.feed.type_)
let sort = $state(data.feed.sort)
let type = $state(data.feed.value.type_)
let sort = $state(data.feed.value.sort)
$effect(() => {
if (type) settings.defaultSort.feed = type
@@ -63,8 +63,8 @@
</header>
<FeedComponent
bind:posts={data.feed.posts.posts}
bind:feedData={() => data.feed, v => (postFeeds.value.main.data = v)}
bind:posts={data.feed.value.posts.posts}
bind:feedData={() => data.feed.value, v => (postFeeds.value.main.data = v)}
feedId="main"
/>
<svelte:element
@@ -74,7 +74,7 @@
class="mt-auto"
>
<Pageination
cursor={{ next: data.feed.cursor.next }}
cursor={{ next: data.feed.value.cursor.next }}
href={page =>
typeof page == 'number' ? `?page=${page}` : `?cursor=${page}`}
back={false}
+15 -12
View File
@@ -1,5 +1,6 @@
import { t } from '$lib/i18n/translations.js'
import { postFeed } from '$lib/lemmy/postfeed.svelte.js'
import { ReactiveState } from '$lib/promise.svelte.js'
import { settings } from '$lib/settings.svelte'
import type { ListingType, SortType } from 'lemmy-js-client'
import { ChevronDoubleUp } from 'svelte-hero-icons'
@@ -13,18 +14,20 @@ export async function load({ url, fetch }) {
(url.searchParams.get('type') as ListingType) || settings.defaultSort.feed
return {
feed: await postFeed({
id: 'main',
request: {
page_cursor: cursor,
sort: sort,
type_: listingType,
limit: 20,
show_hidden: settings.posts.showHidden,
},
url: url,
fetch: fetch,
}),
feed: new ReactiveState(
await postFeed({
id: 'main',
request: {
page_cursor: cursor,
sort: sort,
type_: listingType,
limit: 20,
show_hidden: settings.posts.showHidden,
},
url: url,
fetch: fetch,
}),
),
contextual: {
actions: [
{