From 393ad4f31f9d771e2dc0021593d6fb70850fa93f Mon Sep 17 00:00:00 2001 From: James Xylight Date: Fri, 14 Feb 2025 14:42:14 -0800 Subject: [PATCH] misc: tweak UI everywhere --- .../lemmy/comment/CommentForm.svelte | 14 +++++++++----- .../lemmy/modal/ImageUploadModal.svelte | 13 ++++++++----- .../lemmy/post/link/PostLink.svelte | 18 ++++++++++++------ .../markdown/renderers/MdImage.svelte | 2 ++ src/lib/components/ui/generic/Skeleton.svelte | 6 +++--- src/lib/components/ui/navbar/Profile.svelte | 19 ++++--------------- .../ui/navbar/commands/Commands.svelte | 11 +++++------ src/lib/mono/popover/Menu.svelte | 8 ++++---- src/lib/mono/popover/Popover.svelte | 3 ++- .../post/[instance]/[id=integer]/+page.svelte | 4 ++-- 10 files changed, 51 insertions(+), 47 deletions(-) diff --git a/src/lib/components/lemmy/comment/CommentForm.svelte b/src/lib/components/lemmy/comment/CommentForm.svelte index a8b0de48..001eafe3 100644 --- a/src/lib/components/lemmy/comment/CommentForm.svelte +++ b/src/lib/components/lemmy/comment/CommentForm.svelte @@ -10,7 +10,7 @@ import { Button } from 'mono-svelte' import { t } from '$lib/translations' import { errorMessage } from '$lib/lemmy/error' - import { Icon, Language, XMark } from 'svelte-hero-icons' + import { ArrowUp, Icon, Language, XMark } from 'svelte-hero-icons' interface Props { postId: number @@ -104,7 +104,8 @@ {#snippet target()} {/if} diff --git a/src/lib/components/lemmy/modal/ImageUploadModal.svelte b/src/lib/components/lemmy/modal/ImageUploadModal.svelte index 00f5a0ce..ad7750ab 100644 --- a/src/lib/components/lemmy/modal/ImageUploadModal.svelte +++ b/src/lib/components/lemmy/modal/ImageUploadModal.svelte @@ -28,7 +28,7 @@ let progress = $state(1) let previewURLs = $derived( - preview && image ? Array.from(image).map(URL.createObjectURL) : undefined, + preview && image ? Array.from(image).map(URL.createObjectURL) : undefined ) async function upload() { @@ -48,8 +48,8 @@ .catch((err) => { toast({ content: errorMessage(err), type: 'error' }) return 'Failed to upload' - }), - ), + }) + ) ) ).filter((i) => i != undefined) @@ -108,9 +108,12 @@ {/each} {:else} -
+
- {$t('form.post.selectFile')} + {$t('form.post.selectFile')}
{/if} {#if thumbnail_url} @@ -54,14 +55,19 @@ -inset-px" /> {/if} -
+
{#if richURL} - + {richURL.hostname} {/if} @@ -73,7 +79,7 @@ {embed_title} {#if embed_description} -

+

{embed_description.slice(0, 300)}{embed_description.length > 300 ? '...' : ''} diff --git a/src/lib/components/markdown/renderers/MdImage.svelte b/src/lib/components/markdown/renderers/MdImage.svelte index 0e16dda1..177a373f 100644 --- a/src/lib/components/markdown/renderers/MdImage.svelte +++ b/src/lib/components/markdown/renderers/MdImage.svelte @@ -39,6 +39,8 @@ src={optimizeImageURL(href, 1024)} {title} alt={text} + width={300} + height={300} class="object-contain w-auto h-auto max-h-80 inline rounded-lg" /> diff --git a/src/lib/components/ui/generic/Skeleton.svelte b/src/lib/components/ui/generic/Skeleton.svelte index 337adf3c..cdd9ac29 100644 --- a/src/lib/components/ui/generic/Skeleton.svelte +++ b/src/lib/components/ui/generic/Skeleton.svelte @@ -1,11 +1,11 @@

diff --git a/src/lib/components/ui/navbar/Profile.svelte b/src/lib/components/ui/navbar/Profile.svelte index 3c1221e5..934d7e0a 100644 --- a/src/lib/components/ui/navbar/Profile.svelte +++ b/src/lib/components/ui/navbar/Profile.svelte @@ -70,9 +70,9 @@ {#snippet target()}
@@ -97,18 +97,7 @@ {/if} {/snippet} - {#if profile.data?.user} - - {:else} - {$t('nav.menu.label')} - {/if} + {$t('nav.menu.label')} {#if profile.data?.jwt} {#snippet prefix()} diff --git a/src/lib/components/ui/navbar/commands/Commands.svelte b/src/lib/components/ui/navbar/commands/Commands.svelte index 7209e090..a71f2a40 100644 --- a/src/lib/components/ui/navbar/commands/Commands.svelte +++ b/src/lib/components/ui/navbar/commands/Commands.svelte @@ -27,7 +27,7 @@ profile.data, profileData.profiles, theme.data, - page.data.contextual?.actions, + page.data.contextual?.actions ) }) @@ -95,7 +95,7 @@ score: Math.max( fuzzySearch(action.name, term), fuzzySearch(group.name, term), - action.detail ? fuzzySearch(action.detail, term) : -1, + action.detail ? fuzzySearch(action.detail, term) : -1 ), })) .filter((action) => action.score > 0) @@ -106,7 +106,7 @@ actions: scoredActions, score: Math.max( fuzzySearch(group.name, term), - ...scoredActions.map((a) => a.score), + ...scoredActions.map((a) => a.score) ), } }) @@ -140,7 +140,7 @@ function flattenActions( actions: Action[], - subaction: boolean = true, + subaction: boolean = true ): Action[] { return actions.flatMap((action) => [ action, @@ -238,7 +238,7 @@ }) let flattenedActions = $derived( - filteredGroups.flatMap((group) => group.actions), + filteredGroups.flatMap((group) => group.actions) ) $effect(() => { @@ -250,7 +250,6 @@ {#snippet popover()}
{@render children?.()}
diff --git a/src/lib/mono/popover/Popover.svelte b/src/lib/mono/popover/Popover.svelte index d8bac39b..b90b1446 100644 --- a/src/lib/mono/popover/Popover.svelte +++ b/src/lib/mono/popover/Popover.svelte @@ -124,7 +124,8 @@ {#if open}
- removeToast(id), + removeToast(id) ) } } catch (err) { @@ -176,7 +176,7 @@ let commenting = $state(false) let remoteView = $derived( - page.params.instance?.toLowerCase() != instance.data.toLowerCase(), + page.params.instance?.toLowerCase() != instance.data?.toLowerCase() )