From 0c0509d436d8f74181f61ebc5289a9e1bad19732 Mon Sep 17 00:00:00 2001 From: Xylight Date: Sun, 20 Oct 2024 16:14:45 -0700 Subject: [PATCH] fix: change keying of virtual feeds --- package.json | 1 + src/lib/components/lemmy/post/Post.svelte | 11 ++++---- src/lib/components/lemmy/post/PostMeta.svelte | 27 ++++--------------- .../lemmy/post/feed/VirtualFeed.svelte | 27 ++++++++++--------- 4 files changed, 25 insertions(+), 41 deletions(-) diff --git a/package.json b/package.json index e341dccc..6576680c 100644 --- a/package.json +++ b/package.json @@ -30,6 +30,7 @@ "svelte-hero-icons": "^5.2.0", "svelte-infinite-scroll": "^2.0.1", "svelte-markdown": "^0.4.1", + "svelte-virtual-scroll-list": "^1.3.0", "sveltekit-i18n": "^2.4.2", "tailwindcss": "^3.3.3", "tslib": "^2.4.1", diff --git a/src/lib/components/lemmy/post/Post.svelte b/src/lib/components/lemmy/post/Post.svelte index 3bc281e2..0f1c7143 100644 --- a/src/lib/components/lemmy/post/Post.svelte +++ b/src/lib/components/lemmy/post/Post.svelte @@ -36,9 +36,8 @@ export let hideCommunity = false export let view = $userSettings.view - $: type = mediaType(post.post.url, view) - $: tags = parseTags(post.post.name) + $: type = mediaType(post.post.url, view) $: rule = getTagRule(tags.tags) $: hideTitle = @@ -141,7 +140,7 @@ > {#if rule != 'hide'} {#if view == 'list' || view == 'compact'} {/if} {#if actions} - + {:else if view == 'compact'}
diff --git a/src/lib/components/lemmy/post/PostMeta.svelte b/src/lib/components/lemmy/post/PostMeta.svelte index eb4e3e5e..02d1693b 100644 --- a/src/lib/components/lemmy/post/PostMeta.svelte +++ b/src/lib/components/lemmy/post/PostMeta.svelte @@ -18,9 +18,9 @@ let extracted: Tag[] = [] - const newTitle = title.replace( - /^(\[.[^\]]+\])|(\[.[^\]]+\])$/g, - (match, content) => { + const newTitle = title + .toString() + .replace(/^(\[.[^\]]+\])|(\[.[^\]]+\])$/g, (match, content) => { const contents = match.split(',').map((part: string) => part.trim()) contents @@ -33,8 +33,7 @@ ) }) return '' - } - ) + }) return { tags: extracted, @@ -98,22 +97,6 @@ export let tags: Tag[] = [] - let displayTitle = title - - const update = () => { - if (tags.length == 0) { - const result = parseTags(title) - tags = result.tags - displayTitle = result.title - } - } - - $: { - if (title) { - update() - } - } - let popoverOpen = false @@ -306,7 +289,7 @@ data-sveltekit-preload-data="tap" > - {#each items as row, index (row.index)} -
  • - {#if posts[row.index]} + {#each items as row, index (posts[row.index]?.post.id)} + {#if posts[row.index]} + {@const post = posts?.[row.index]} +
  • { posts = posts.toSpliced(row.index, 1) }} > - {/if} -
  • + + {/if} {/each}